osc/rdma: set state_region->base for non accelerated btl#10462
Merged
awlauria merged 1 commit intoopen-mpi:mainfrom Jun 10, 2022
Merged
osc/rdma: set state_region->base for non accelerated btl#10462awlauria merged 1 commit intoopen-mpi:mainfrom
awlauria merged 1 commit intoopen-mpi:mainfrom
Conversation
In allocate_state_shared(), state_region->base is used to calculate peer->state when CPU atomics is not used. Currently it is set only if accelerated btl is used, but it is used for non-accelerated btl too, causing peer->state to be set incorrectly. This patch addressed the issue. Signed-off-by: Wei Zhang <wzam@amazon.com>
bwbarrett
approved these changes
Jun 10, 2022
Contributor
|
@wzamazon can you bring this back to v5.0.x? |
Contributor
Author
|
Sure. will do |
Contributor
Author
|
backport PR #10465 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In allocate_state_shared(), state_region->base is used to
calculate peer->state when CPU atomics is not used.
Currently it is set only if accelerated btl is used,
but it is used for non-accelerated btl too, causing peer->state
to be set incorrectly.
This patch addressed the issue.
Signed-off-by: Wei Zhang wzam@amazon.com